Bug: SQLite shell does not build on Windows with SQLITE_OMIT_COMPLETE

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug: SQLite shell does not build on Windows with SQLITE_OMIT_COMPLETE

Victor Costan
The amalgamation build ships two definitions of sqlite3_complete(). Most
builds use the one in sqlite3.c. If SQLITE_OMIT_COMPLETE is defined,
shell.c supplies a stub definition -- thank you very much for adding that!

Unfortunately, the stub definition in shell.c does not have the SQLITE_API
prefix. This causes our Windows compiler to complain. Can you please add
SQLITE_API to the shell.c line that starts with "int sqlite3_complete("?

Thank you very much,
    Victor
_______________________________________________
sqlite-users mailing list
[hidden email]
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
Reply | Threaded
Open this post in threaded view
|

Re: Bug: SQLite shell does not build on Windows with SQLITE_OMIT_COMPLETE

Dan Kennedy-4
On 11/16/2018 08:41 PM, Victor Costan wrote:

> The amalgamation build ships two definitions of sqlite3_complete(). Most
> builds use the one in sqlite3.c. If SQLITE_OMIT_COMPLETE is defined,
> shell.c supplies a stub definition -- thank you very much for adding that!
>
> Unfortunately, the stub definition in shell.c does not have the SQLITE_API
> prefix. This causes our Windows compiler to complain. Can you please add
> SQLITE_API to the shell.c line that starts with "int sqlite3_complete("?
>
> Thank you very much,
>     Victor
> _______________________________________________
> sqlite-users mailing list
> [hidden email]
> http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
>

Thanks for reporting this. Should now be fixed here:

   https://www.sqlite.org/src/info/d584a0cb51281594

Dan.


_______________________________________________
sqlite-users mailing list
[hidden email]
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
Reply | Threaded
Open this post in threaded view
|

Re: Bug: SQLite shell does not build on Windows with SQLITE_OMIT_COMPLETE

Victor Costan
Thank you very much, Dan!

I was about to come back to report that my fix is incorrect. Your fix does
the trick. Thank you!

     Victor

On Fri, Nov 16, 2018 at 6:38 AM Dan Kennedy <[hidden email]> wrote:

> On 11/16/2018 08:41 PM, Victor Costan wrote:
> > The amalgamation build ships two definitions of sqlite3_complete(). Most
> > builds use the one in sqlite3.c. If SQLITE_OMIT_COMPLETE is defined,
> > shell.c supplies a stub definition -- thank you very much for adding
> that!
> >
> > Unfortunately, the stub definition in shell.c does not have the
> SQLITE_API
> > prefix. This causes our Windows compiler to complain. Can you please add
> > SQLITE_API to the shell.c line that starts with "int sqlite3_complete("?
> >
> > Thank you very much,
> >     Victor
> > _______________________________________________
> > sqlite-users mailing list
> > [hidden email]
> > http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
> >
>
> Thanks for reporting this. Should now be fixed here:
>
>    https://www.sqlite.org/src/info/d584a0cb51281594
>
> Dan.
>
>
> _______________________________________________
> sqlite-users mailing list
> [hidden email]
> http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
>
_______________________________________________
sqlite-users mailing list
[hidden email]
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users