Bug report

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug report

Mark Benningfield
In version 3.30.1 ( check-in  [9b14eb77] ), file "sqlite3ext.h"

618  #define sqlite3_stmt_isexplain         sqlite3_api->isexplain
619  #define sqlite3_value_frombind         sqlite3_api->frombind

should be

618  #define sqlite3_stmt_isexplain         sqlite3_api->stmt_isexplain
619  #define sqlite3_value_frombind         sqlite3_api->value_frombind

Errors:
"isexplain" is not a member of struct sqlite3_api
"frombind" is not a member of struct sqlite3_api



--
Sent from: http://sqlite.1065341.n5.nabble.com/
_______________________________________________
sqlite-users mailing list
[hidden email]
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
Reply | Threaded
Open this post in threaded view
|

Re: Bug report

Mark Benningfield
Well, I kinda thought that this would be fixed on the next release. The
"value_frombind" typo in particular prevents FTS3/4 from being built as a
loadable extension. I only have one legacy application that uses FTS3/4 that
way, and fixing these typos whenever I do a Fossil pull of the latest
version takes a grand total of about 2 seconds, but it would be nice not to
have to remember to do it every time :)



--
Sent from: http://sqlite.1065341.n5.nabble.com/
_______________________________________________
sqlite-users mailing list
[hidden email]
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
Reply | Threaded
Open this post in threaded view
|

Re: Bug report

Warren Young
On Jan 23, 2020, at 7:02 AM, Mark Benningfield <[hidden email]> wrote:
>
> ...whenever I do a Fossil pull of the latest
> version takes a grand total of about 2 seconds, but it would be nice not to
> have to remember to do it every time :)

If you’re having to reapply the change on every Fossil update, you’re probably making the change to the wrong place in the code: you’re changing a generated file rather than a proper source file.

Saying “fossil up” or “fossil up release” should merge your local edits into the new release automatically unless upstream changes something nearby or on those same lines.

I don’t say this expecting that these problems will remain unfixed upstream, just as general forward-looking advice.  Fossil can be a useful aide in carrying local changes from one release to the next.

There are more advanced methods beyond that, such as private branches and autosync=0, but at that point we should take it up on the Fossil forum.
_______________________________________________
sqlite-users mailing list
[hidden email]
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users