Build error in SQLite 3.18 if SQLITE_UNTESTABLE is defined

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Build error in SQLite 3.18 if SQLITE_UNTESTABLE is defined

Priebe, Sebastian
Hello,

shell.c fails to build with:
shell.c: In function 'do_meta_command':
shell.c:6442:50: error: 'sql_trace_callback' undeclared (first use in this function)
       sqlite3_trace_v2(p->db, SQLITE_TRACE_STMT, sql_trace_callback,p->traceOut);
                                                  ^
shell.c:6442:50: note: each undeclared identifier is reported only once for each function it appears in
make: *** [sqlite3-shell.o] Error 1

Looking at the source code: the function sql_trace_callback is only available if SQLITE_UNTESTABLE is not defined, but at the place it is used there is no such restiction.

Greetings
Sebastian




------------------------------------------------------------------
     +++ CADCON ist Mitglied der SII Group +++
Mehr auf unserer neuen Homepage > www.cadcon.de
-------------------------------------------------------------------

CADCON
Ingenieurgesellschaft mbH & Co. KG
Geschaeftsfuehrer: Robert Bauer
Sitz der Gesellschaft: 86368 Gersthofen
Registergericht: Amtsgericht Augsburg HRA 14521

_______________________________________________
sqlite-users mailing list
[hidden email]
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
Reply | Threaded
Open this post in threaded view
|

Re: Build error in SQLite 3.18 if SQLITE_UNTESTABLE is defined

Richard Hipp-3
I'm curious:  Why do you want to make SQLite untestable?

On 4/24/17, Priebe, Sebastian <[hidden email]> wrote:

> Hello,
>
> shell.c fails to build with:
> shell.c: In function 'do_meta_command':
> shell.c:6442:50: error: 'sql_trace_callback' undeclared (first use in this
> function)
>        sqlite3_trace_v2(p->db, SQLITE_TRACE_STMT,
> sql_trace_callback,p->traceOut);
>                                                   ^
> shell.c:6442:50: note: each undeclared identifier is reported only once for
> each function it appears in
> make: *** [sqlite3-shell.o] Error 1
>
> Looking at the source code: the function sql_trace_callback is only
> available if SQLITE_UNTESTABLE is not defined, but at the place it is used
> there is no such restiction.
>
> Greetings
> Sebastian
>
>
>
>
> ------------------------------------------------------------------
>      +++ CADCON ist Mitglied der SII Group +++
> Mehr auf unserer neuen Homepage > www.cadcon.de
> -------------------------------------------------------------------
>
> CADCON
> Ingenieurgesellschaft mbH & Co. KG
> Geschaeftsfuehrer: Robert Bauer
> Sitz der Gesellschaft: 86368 Gersthofen
> Registergericht: Amtsgericht Augsburg HRA 14521
>
> _______________________________________________
> sqlite-users mailing list
> [hidden email]
> http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
>


--
D. Richard Hipp
[hidden email]
_______________________________________________
sqlite-users mailing list
[hidden email]
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
Reply | Threaded
Open this post in threaded view
|

Re: Build error in SQLite 3.18 if SQLITE_UNTESTABLE is defined

Priebe, Sebastian-2
In reply to this post by Priebe, Sebastian
Hello,

this error still exists.
Please fix it.

Greetings
Sebastian




SII Technologies GmbH
Geschäftsführer: Robert Bauer
Sitz der Gesellschaft: 86167 Augsburg
Registergericht: Amtsgericht Augsburg HRB 31802-----Ursprüngliche Nachricht-----
Von: Priebe, Sebastian
Gesendet: Montag, 24. April 2017 16:50
An: [hidden email]
Betreff: Build error in SQLite 3.18 if SQLITE_UNTESTABLE is defined

Hello,

shell.c fails to build with:
shell.c: In function 'do_meta_command':
shell.c:6442:50: error: 'sql_trace_callback' undeclared (first use in this function)
       sqlite3_trace_v2(p->db, SQLITE_TRACE_STMT, sql_trace_callback,p->traceOut);
                                                  ^
shell.c:6442:50: note: each undeclared identifier is reported only once for each function it appears in
make: *** [sqlite3-shell.o] Error 1

Looking at the source code: the function sql_trace_callback is only available if SQLITE_UNTESTABLE is not defined, but at the place it is used there is no such restiction.

Greetings
Sebastian


_______________________________________________
sqlite-users mailing list
[hidden email]
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
Reply | Threaded
Open this post in threaded view
|

Re: Build error in SQLite 3.18 if SQLITE_UNTESTABLE is defined

Richard Hipp-3
On 4/10/18, Priebe, Sebastian <[hidden email]> wrote:
> this error still exists.
> Please fix it.

You still have not answered my question:  Why do you want to make
SQLite untestable?

--
D. Richard Hipp
[hidden email]
_______________________________________________
sqlite-users mailing list
[hidden email]
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
Reply | Threaded
Open this post in threaded view
|

Re: Build error in SQLite 3.18 if SQLITE_UNTESTABLE is defined

Priebe, Sebastian-2
> You still have not answered my question:  Why do you want to make SQLite untestable?

Because we don't want the extra code to make it testable in our project.
Imho all available build configurations should build.




SII Technologies GmbH
Geschäftsführer: Robert Bauer
Sitz der Gesellschaft: 86167 Augsburg
Registergericht: Amtsgericht Augsburg HRB 31802-----Ursprüngliche Nachricht-----
Von: [hidden email] <[hidden email]> Im Auftrag von Richard Hipp
Gesendet: Dienstag, 10. April 2018 12:29
An: SQLite mailing list <[hidden email]>
Cc: Priebe, Sebastian <[hidden email]>
Betreff: Re: [sqlite] Build error in SQLite 3.18 if SQLITE_UNTESTABLE is defined

On 4/10/18, Priebe, Sebastian <[hidden email]> wrote:
> this error still exists.
> Please fix it.

You still have not answered my question:  Why do you want to make SQLite untestable?

--
D. Richard Hipp
[hidden email]

_______________________________________________
sqlite-users mailing list
[hidden email]
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users
Reply | Threaded
Open this post in threaded view
|

Re: Build error in SQLite 3.18 if SQLITE_UNTESTABLE is defined

Richard Hipp-3
On 4/10/18, Priebe, Sebastian <[hidden email]> wrote:
> Imho all available build configurations should build.

Sorry to disappoint.  There are lots of legacy compile-time options in
SQLite that we do not verify.  We have a small subset of compile-time
options that we support.

I have checked in a change so that the command-line shell now builds
with SQLITE_UNTESTABLE.  It builds now.  And it seems to work.  But we
are not certain that it works in all cases, since it is now
untestable.  :-)

Compiling SQLite with SQLITE_UNTESTABLE reduces the size of the
sqlite3.o binary from 485808 bytes down to 483245 bytes - a savings of
2563 bytes or 0.53%.  (Built with gcc 5.4.0 and -Os.)
--
D. Richard Hipp
[hidden email]
_______________________________________________
sqlite-users mailing list
[hidden email]
http://mailinglists.sqlite.org/cgi-bin/mailman/listinfo/sqlite-users